JUCE icon indicating copy to clipboard operation
JUCE copied to clipboard

Fixes #1431: Incorrect results from exponentModulo.

Open ianacaburian opened this issue 1 year ago • 0 comments

Changes:

  • Removed incorrect mod op on exponent.
  • Handled base case for zero exponent.

Tests:

  • Tested against modPow by jsbn
  • Tested 100 runs of random hex strings with lengths 300 - 1000 using fast-check: ✓ src/JuceBigInteger.test.ts (1) 1776566ms ✓ JuceBigInteger (1) 1776565ms ✓ exponentModulo (1) 1776565ms
  • Double-checked counter examples on Omni Calculator:
    • b=x, e=0, m=y
    • b=3, e=8, m=5
    • b=0x1400000007, e=0x1400000006, m=0x1400000005

Source:

Thank you for submitting a pull request.

Please make sure you have read and followed our contribution guidelines (.github/contributing.md in this repository). Your pull request will not be accepted if you have not followed the instructions.

ianacaburian avatar Sep 30 '24 16:09 ianacaburian