diart icon indicating copy to clipboard operation
diart copied to clipboard

Update matplotlib Requirement

Open QuentinFuxa opened this issue 10 months ago • 1 comments

The current matplotlib version requirement in diart (matplotlib>=3.3.3,<3.6.0) is outdated and causes installation failures with Python 3.13 due to issues with building the matplotlib wheel: ERROR: Failed building wheel for matplotlib

Proposed Update: I suggest raising the matplotlib version requirement to include more recent versions. I have tested the main functionalities of diart with the latest version of matplotlib, and they work correctly. You can see my implementation here: whisper_streaming_web.

Testing Notes: While the main functionalities seem to work with the updated version, I have not tested the figure generation code at line 122 in dsrc/diart/sinks.py.

And thank you for maintaining this great project!

Quentin

QuentinFuxa avatar Jan 19 '25 21:01 QuentinFuxa

We're experiencing similar issues when installing with Python 3.11.

<long trace of C compiler errors above>

  at ~/.local/pipx/venvs/poetry/lib/python3.13/site-packages/poetry/installation/chef.py:164 in _prepare
      160│ 
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│ 
      163│             if error is not None:
    → 164│                 raise error from None
      165│ 
      166│             return path
      167│ 
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but 
with matplotlib (3.5.3) not supporting PEP 517 builds. You can verify this by running 
'pip wheel --no-cache-dir --use-pep517 "matplotlib (==3.5.3)"'.

Running pip wheel --no-cache-dir --use-pep517 "matplotlib (==3.5.3)" does indeed re-confirm the issue with matplotlib.

@juanmc2005 Is there backing for a PR that updates Python version support from 3.8-10 (3.8 is EOL and 3.9 has 9 months until EOL)? I have created one here https://github.com/juanmc2005/diart/pull/269.

@QuentinFuxa Do I understand you correctly that bumping Matplotlib to more recent versions allows installing diart with Python 3.13 without hiccups?

JakobHavtorn avatar Feb 03 '25 21:02 JakobHavtorn