d3book icon indicating copy to clipboard operation
d3book copied to clipboard

d3book

Open JasonSqz opened this issue 3 years ago • 5 comments

  • [x] section 0.1.2 a bit unclear how to hide the sidebar, maybe say it's on the top bar of the page.

  • [x] section 1.1 downloading the repo is a bit overkill. I think we can just open the page -> right click -> save as -> add .html

  • [x] section 2.3 extra `

  • [x] section 3.2.3 maybe could explain a bit why the graphs can be interactive.

  • [x] section 3.3.1 maybe add a link to download five_green_circles.html again.

  • [x] section 3.5 I did not realize stroke is an attr and used append() first.

  • [ ] section 3.5 Upon looking at the solution, I think both .attr("stroke-width", "5") and .attr("stroke-width", 5) works.

  • [x] section 3.7 I think it's more coherent to move that to section 4

  • [x] section 4.3 I refreshed the page for the next section and svg is no longer defined.

  • [ ] section 4.8 Maybe add a little bit more explanation.

  • [x] section 5.3.1 inconsistency in var and let

Went through all sections until section 6.

JasonSqz avatar Apr 19 '22 18:04 JasonSqz

  • [x] For each exercise with solutions, maybe add a link directly to the page of solutions in section 15; Also add the exercise numbers in section '15 Solutions' to make it easier to find and try.

  • [x] For the solution 'Update, Enter, and Exit: vertical bar chart' in section 15, the answer shown in the book down is inconsistent with that in the given link.

  • [x] For section 5.3.1, the annotation inside the chunk is confusing: which is for R and which is for JavaScript? ; using '#' in the chunk makes it hard to direct copy and paste JavaScript codes

anniechencan avatar Apr 20 '22 13:04 anniechencan

  • section 6, maybe change some of the section into exercise. (Possibly all sections and provide some guidance) i think this is a really import section and scaling is not very easy to understand (Need to do it instead of looking at codes).
  • I think one of the problem after section 5 is the lack of explanations. It's fine if someone is following along with the lecture recording. However, for those who do not have access to the recording, it might bring some confusion.

JasonSqz avatar Apr 25 '22 21:04 JasonSqz

Same opinion as Jason on section 6, and instead of directly giving an HTML code to download, it's better to provide instructions that can be interactive on the page, just similar to the format in section 4.9.

anniechencan avatar Apr 26 '22 18:04 anniechencan

  • [x] For section 11.4 Blockbuilder 2015-2020, the link direct to Mike Bostock shows that the author no longer maintains the codes on Blockbuilder and instead moves all of the resources to Observable. So not sure whether still keep this part.

  • [x] Section 14.1, the second link “So you’ve been asked to make a reprex” no longer avaliable.

anniechencan avatar Apr 26 '22 19:04 anniechencan

Add check marks so we can indicate which issues were addressed in pull requests.

jtr13 avatar Apr 27 '22 14:04 jtr13