EDAV icon indicating copy to clipboard operation
EDAV copied to clipboard

Contributing to this Resource Chapter

Open jtr13 opened this issue 6 years ago • 6 comments

Make clear that the detailed instructions in the chapter are for editing changes made on GitHub directly. For more involved changes including R code, it's necessary to install Git, fork then clone edav.info, do work on a branch, commit and push the changes, and then submit a pull request. (This is workflow 4 in the Git slides: https://github.com/jtr13/codehelp/blob/master/GitHubWorkflowPt2.pdf

jtr13 avatar Feb 14 '19 19:02 jtr13

Hi Joyce,

I tried to preview the chapter after I added some instructions into it. However, it still didn't work after I installed all the packages in the "Description" file. I got the following error message:

Error in file(con, "r") : cannot open the connection In addition: Warning message: In file(con, "r") : cannot open file 'index.md': No such file or directory

Is there anyway I can solve this problem?

xhqkatrina avatar Feb 18 '19 05:02 xhqkatrina

Try rendering the whole book locally bookdown::render_book("index.Rmd") and then make changes to individual chapters and then preview them. You may want to experiment first with the bookdown-practice repo.

jtr13 avatar Feb 18 '19 12:02 jtr13

Thanks! I can preview the chapters now. There was just one small problem when I rendered the book: one code chunk in the file "import_data.Rmd" produces an error that I could not fix. It was a problem with reading data from URL. So I chose to set "eval = FALSE" for that code chunk in order to render the book for now. I will keep adding content and I guess we can go through this problem together during tomorrow's meeting?

xhqkatrina avatar Feb 18 '19 17:02 xhqkatrina

Ok great! Yes, we'll try to figure it out tomorrow. It might have to do with the location of the file that it's trying to read.

jtr13 avatar Feb 18 '19 17:02 jtr13

Hi Joyce, I have updated the content on contributing to EDAV with Git. In addition, I have also finalized the workflow notes chapter. Please take a look at this branch: https://github.com/xhqkatrina/EDAV/tree/Contribute%26Workflow

There is one additional question about the cleveland chapter. Running that chapter Rmd file gives me an error on the fct_reorder2() function: object 'first2' not found I remembered in Thursday's you talked about the updates in the "forcats" package, so I installed the development version of "forcats" from github. However, I am still getting this error. Do you have any idea on how to solve this problem? Thanks!

xhqkatrina avatar Feb 23 '19 01:02 xhqkatrina

Great, will take a look. Re: first2... it should work with the dev version. Try closing RStudio, reopening and checking again. Also check the version of forcats with sessionInfo(). It should be forcats_0.4.0.9000.

jtr13 avatar Feb 23 '19 04:02 jtr13