eslint-plugin-react
eslint-plugin-react copied to clipboard
[Docs] Recategorize rules in readme
Closes #3216 .
~~The categories are taken from https://eslint.org/docs/rules/ .~~
Rendered Readme: https://github.com/yannickcr/eslint-plugin-react/blob/793d5374e09beb34dfcbc4ac3e8494f6ecaf48f1/README.md
Codecov Report
Merging #3226 (5d8455f) into master (24bf594) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 121 121
Lines 8519 8519
Branches 3075 3075
=======================================
Hits 8320 8320
Misses 199 199
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/rules/boolean-prop-naming.js | 99.27% <ø> (ø) |
|
| lib/rules/destructuring-assignment.js | 98.93% <ø> (ø) |
|
| lib/rules/function-component-definition.js | 98.52% <ø> (ø) |
|
| lib/rules/jsx-boolean-value.js | 100.00% <ø> (ø) |
|
| lib/rules/jsx-filename-extension.js | 100.00% <ø> (ø) |
|
| lib/rules/jsx-fragments.js | 98.93% <ø> (ø) |
|
| lib/rules/jsx-pascal-case.js | 100.00% <ø> (ø) |
|
| lib/rules/no-invalid-html-attribute.js | 96.71% <ø> (ø) |
|
| lib/rules/no-multi-comp.js | 100.00% <ø> (ø) |
|
| lib/rules/no-set-state.js | 100.00% <ø> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 24bf594...5d8455f. Read the comment docs.
I'm not sure that's true, given that some of the jsx rules cover non-jsx as well.
As for best practice, of course it's subjective, but its perfectly fine to be opinionated. All of the things I've indicated are prevailing community-wide best practices; if someone disagrees, they are free to disable the rule.
Codecov Report
Merging #3226 (1134494) into master (01ab399) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 130 130
Lines 9218 9218
Branches 3341 3341
=======================================
Hits 8995 8995
Misses 223 223
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/rules/boolean-prop-naming.js | 99.39% <ø> (ø) |
|
| lib/rules/destructuring-assignment.js | 97.39% <ø> (ø) |
|
| lib/rules/function-component-definition.js | 99.00% <ø> (ø) |
|
| lib/rules/jsx-boolean-value.js | 100.00% <ø> (ø) |
|
| lib/rules/jsx-filename-extension.js | 100.00% <ø> (ø) |
|
| lib/rules/jsx-fragments.js | 98.93% <ø> (ø) |
|
| lib/rules/jsx-pascal-case.js | 100.00% <ø> (ø) |
|
| lib/rules/no-multi-comp.js | 100.00% <ø> (ø) |
|
| lib/rules/no-set-state.js | 100.00% <ø> (ø) |
|
| lib/rules/no-typos.js | 100.00% <ø> (ø) |
|
| ... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.