eslint-plugin-react icon indicating copy to clipboard operation
eslint-plugin-react copied to clipboard

Published 20 hours ago • verified publisher icon jsx-eslint

WIP: react version detection in a monorepo

Open migueloller opened this issue 5 years ago • 6 comments

WIP pull request to track progress on #2218 .

migueloller avatar Mar 29 '20 06:03 migueloller

Seems like a good first start, but this would need tests.

ljharb avatar May 09 '20 16:05 ljharb

@ljharb, yup! I was just trying to see how involved this change was going to be. Because of the current test set up I'm probably going to have to spend some time figuring out the least invasive way to implement the tests.

I'll try to look into this again during the weekend.

migueloller avatar May 11 '20 16:05 migueloller

@migueloller any interest in completing this PR?

ljharb avatar Sep 20 '21 19:09 ljharb

@ljharb, in addition to the small tweak I did to the existing tests, were there specific test cases you were thinking we should cover?

migueloller avatar Sep 20 '21 20:09 migueloller

My hope would be, inside tests/files, a recreation of a monorepo setup where detect would have returned the wrong result without your change.

ljharb avatar Sep 21 '21 01:09 ljharb

@ljharb, got it. That sounds reasonable! I will do my best to get something set up sometime soon. I apologize I haven't put in more work on this PR, I've been busy 😬

migueloller avatar Sep 27 '21 15:09 migueloller