eslint-plugin-jsx-a11y icon indicating copy to clipboard operation
eslint-plugin-jsx-a11y copied to clipboard

Ignore contenteditable elements in no-noninteractive-element-interactions

Open JoshuaKGoldberg opened this issue 3 years ago • 2 comments

Fixes #525

JoshuaKGoldberg avatar Feb 24 '22 12:02 JoshuaKGoldberg

Codecov Report

Merging #835 (9aa878b) into main (3d77c84) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         103      104    +1     
  Lines        1541     1545    +4     
  Branches      518      519    +1     
=======================================
+ Hits         1530     1534    +4     
  Misses         11       11           
Impacted Files Coverage Δ
...rc/rules/no-noninteractive-element-interactions.js 100.00% <100.00%> (ø)
src/util/isContentEditable.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Feb 24 '22 12:02 codecov[bot]

@JoshuaKGoldberg so, i rebased this, and tweaked the logic slightly (from "not false" to "is true") based on my testing - iow, that browsers normalize all values outside the enum of "true", "false", or "inherit" to "false" (and the JS setter refuses any value but those three), and now some tests are failing.

Mind resetting your local branch, and taking a look?

ljharb avatar Aug 08 '22 20:08 ljharb

I'm working on the Flow issues now, will rebase once I'm done...

JoshuaKGoldberg avatar Jan 09 '23 14:01 JoshuaKGoldberg