Ignore contenteditable elements in no-noninteractive-element-interactions
Fixes #525
Codecov Report
Merging #835 (9aa878b) into main (3d77c84) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 103 104 +1
Lines 1541 1545 +4
Branches 518 519 +1
=======================================
+ Hits 1530 1534 +4
Misses 11 11
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...rc/rules/no-noninteractive-element-interactions.js | 100.00% <100.00%> (ø) |
|
| src/util/isContentEditable.js | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@JoshuaKGoldberg so, i rebased this, and tweaked the logic slightly (from "not false" to "is true") based on my testing - iow, that browsers normalize all values outside the enum of "true", "false", or "inherit" to "false" (and the JS setter refuses any value but those three), and now some tests are failing.
Mind resetting your local branch, and taking a look?
I'm working on the Flow issues now, will rebase once I'm done...