Jeff Whitaker

Results 538 comments of Jeff Whitaker

@Zeitsperre are you having a problem with windows wheels only, or also the linux and macosx wheels?

> > @Zeitsperre are you having a problem with windows wheels only, or also the linux and macosx wheels? > > I'm only testing on Linux systems, so nothing for...

@valeriupredoi reported at https://github.com/conda-forge/netcdf4-feedstock/issues/141 that his segfaults were all related to the use of file caching, and if the file is read directly from disk the segfaults go away. Are...

From the discussion at https://github.com/conda-forge/netcdf4-feedstock/issues/141, it looks like at least some of the segfaults are related to using netcdf4-python within threads. netcdf-c is not thread-safe, and releasing the GIL on...

There is an experimental [PR](https://github.com/Unidata/netcdf-c/pull/2505) in netcdf-c that makes the C library threadsafe. This should fix many (all?) of the problems reported here, but won't be available in a released...

Seems like an empty array should be returned, instead of raising an error.

> My experience has been that 10 times/10, doing this is erroneous, since loading nothing from a file is nonsensical. I would rather it fail fast than silently, since on...

We are already checking for boolean index arrays (in order to convert them to integer index arrays), so how about this: ```python diff --git a/src/netCDF4/utils.py b/src/netCDF4/utils.py index c96cc757..dcfeca85 100644 ---...

Tests are failing when an all False boolean index array is used on assignment, which should do nothing (but not raise an exception). The fix is to only do the...

this should fix it ```python diff --git a/src/netCDF4/utils.py b/src/netCDF4/utils.py index c96cc757..dcfeca85 100644 --- a/src/netCDF4/utils.py +++ b/src/netCDF4/utils.py @@ -238,6 +238,10 @@ def _StartCountStride(elem, shape, dimensions=None, grp=None, datashape=None,\ unlim = False #...