Jeff Whitaker

Results 538 comments of Jeff Whitaker

This is intentional - the valid_min/valid_max checks are done on the integer data as it is actually stored in the netcdf file. This is consistent with missing_value and _Fill_Value, which...

I don't think it makes sense to specify valid_min/valid_max with a type that is different than the netcdf variable. What you're asking for is a floating point valid range for...

I see that the _FillValue is 1.e37 - this will get cast to the data type of the variable (short integer), resulting in all the zero values in the array...

I can see how this can be confusing and can create hard to debug errors. Perhaps we should refuse to do the auto-scaling and masking (and throw and exception instead)...

With pull request #708 a warning will be issued if the `_FillValue` cannot be safely cast to the variable data type, and it will not be used to mask the...

We only need hdf5 headers to get the version number - maybe a better solution is to figure out how to get the version number from a library call. nc-config...

looks like we could use this H5get_libversion https://support.hdfgroup.org/HDF5/doc/RM/RM_H5.html#Library-Version and get rid of the H5public.h include in netCDF4.pxi.

Never mind - we still would need to access the hdf5 headers when compiling if we got the version number with a library call. However, looking at the nc-config utility,...

Yep - nc-config only adds CPPFLAGS when you build with ./configure;make;make install, not when you use cmake. Sigh. The problem with using the header to get the library version is...

Maybe we should remove the env vars and just rely on setup.cfg.