delayed_paperclip icon indicating copy to clipboard operation
delayed_paperclip copied to clipboard

Incompatible with Paperclip ~>=2.3.16 (infinite save loop)

Open maxim opened this issue 14 years ago • 7 comments

Starting paperclip somewhere around 2.3.16, saving attachment with delayed_paperclip causes infinite saving loop as the model's attachment_updated_at attribute gets "touched" upon saving, and delayed_paperclip is recognizing that attachment has changed.

I am not sure exactly which version of Paperclip breaks delayed_paperclip, but I have determined that 2.3.11 works, while 2.3.16 or 2.4.1 (latest currently) doesn't.

maxim avatar Sep 09 '11 00:09 maxim

Hi,

Paperclip has undergone quite a change in the latest release, making life easier for people who want to create plugins for it.

I'm currently on holiday, and won't be working on it (as promised to my GF). But I'm back on wednesday, and will be working on it then. I'm sorry for the inconvenience it's causing in the mean time.

Bertg avatar Sep 09 '11 09:09 Bertg

Hi,

We now have test for this. I was checking and I'm not seeing any tests failing. http://travis-ci.org/#!/jstorimer/delayed_paperclip/builds/168893

Could you provide us with an example failing test/code?

Bertg avatar Sep 18 '11 19:09 Bertg

Are you sure those test are running against the latest paperclip ?

pabloalr avatar Nov 04 '11 19:11 pabloalr

By the way, tests are passing with paperclip 2.3.16, but not with ~2.4. I just cloned the repo and added a Appraisal setup for paperclip 2.4...

pabloalr avatar Nov 04 '11 20:11 pabloalr

Hi,

I just added a bunch of version branches, each for every paperclip 2.4.x branch. The test seem to be working fine now.

Could you verify, or add some test that are failing per branch?

Also, could you have a look at this post (https://github.com/jstorimer/delayed_paperclip/issues/46) in regards to future versioning?

Bertg avatar Nov 07 '11 22:11 Bertg

Could you have a look at this (https://github.com/jstorimer/delayed_paperclip/pull/47) patch?

I think it might fix your problem. If it does, could you please confirm?

Bertg avatar Nov 07 '11 23:11 Bertg

Hi Bert.

Just checked out 2.4.5 branch and everything is working as expected.

pabloalr avatar Nov 08 '11 01:11 pabloalr