unknownutil
unknownutil copied to clipboard
Refine `isReadonlyOf` and related
TypeScript offers the Readonly<T> type function and the readonly keyword. However, the isReadonlyOf function seems a bit ambiguous. I propose the following improvements:
- Enhance
isReadonlyOffor Array, Tuple, and Object types. - Introduce
isReadonlyFieldOffor checking/annotating thereadonlystatus of object fields. - Rename
isOptionalOftoisOptionalFieldOfto maintain consistency withisReadonlyFieldOf. This change aligns with the handling of?for object fields.
Several pattern to annotate fields as ? or readonly.
import { is, Predicate } from "./mod.ts";
function optional<K extends PropertyKey>(name: K): K {
return name;
}
function readonly<K extends PropertyKey>(name: K): K {
return name;
}
function annotate<T>(
pred: Predicate<T>,
annotations: { optional?: boolean; readonly?: boolean },
): Predicate<T> {
return pred;
}
const as = {
Optional: <T>(pred: Predicate<T>) => pred,
Readonly: <T>(pred: Predicate<T>) => pred,
};
const pattern1 = is.ObjectOf({
[optional("optionalField")]: is.String,
[readonly("readonlyField")]: is.String,
[readonly(optional("readonlyOptionalField"))]: is.String,
});
const pattern2 = is.ObjectOf({
optionalField: annotate(is.String, { optional: true }),
readonlyField: annotate(is.String, { readonly: true }),
readonlyOptionalField: annotate(is.String, {
optional: true,
readonly: true,
}),
});
const pattern3 = is.ObjectOf({
optionalField: as.Optional(is.String),
readonlyField: as.Readonly(is.String),
readonlyOptionalField: as.Readonly(as.Optional(is.String)),
});
I personally like as.* pattern
The optional annotation is also used as an element of isTupleOf and isParametersOf, so it is impossible to apply pattern 1 of annotating object keys.
What I'm thinking of it is
as.Optional- Optional for a field or an elementas.Readonly- Readonly for a field or an elementis.PartialOf- Optional for all fields or elements of object, array, tuple, etc.is.ReadonlyOf- Readonly for all fields or elements of object, array, tuple, etc.
type A = {
foo?: string;
readonly bar: string;
readonly hoge?: string;
};
// Predicate<A>
const a = is.ObjectOf({
foo: as.Optional(is.String),
bar: as.Readonly(is.String),
hoge: as.Optional(as.Readonly(is.String)),
});
type B = Partial<A>;
// Predicate<B>
const b = is.PartialOf(a);
type C = Readonly<A>;
// Predicate<C>
const c = is.ReadonlyOf(a);
#87