lity icon indicating copy to clipboard operation
lity copied to clipboard

Close button outline

Open RavanH opened this issue 7 years ago • 4 comments
trafficstars

Hi, I'm not an expert but I think for accessibility reasons the style rule outline:none for .lity-close and .lity-close:focus should be removed.

RavanH avatar Jul 07 '18 11:07 RavanH

👍 Feel free top open a PR

jsor avatar Jul 07 '18 20:07 jsor

Sure :)

Related question: there seem to be a lot of "double" css rules that appear both for .lity-close and .lity-close:hoverfocus/active/visited (except text-decoration:none) that could be removed. Or is there a special reason to keep them in both?

RavanH avatar Jul 07 '18 20:07 RavanH

Not sure what you mean exactly, but feel free to open another PR to discuss this.

jsor avatar Jul 07 '18 20:07 jsor

Oh, hang on... this is not the case in current development. I was referring to 2.3.1. Never mind :)

RavanH avatar Jul 07 '18 20:07 RavanH