electron-trpc icon indicating copy to clipboard operation
electron-trpc copied to clipboard

Published 20 hours ago • verified publisher icon jsonnull

fix: invalid mjs bundle

Open ylc395 opened this issue 1 year ago • 8 comments
trafficstars

fix #180

ylc395 avatar Jan 12 '24 04:01 ylc395

Deploy Preview for electron-trpc ready!

Name Link
Latest commit a5e7d4eb7f287c26c2c254a28817ed8ae8120e9e
Latest deploy log https://app.netlify.com/sites/electron-trpc/deploys/65a0c4db1f33b80008adf2b8
Deploy Preview https://deploy-preview-181--electron-trpc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 12 '24 04:01 netlify[bot]

@jsonnull hello, would you like to help to confirm this PR?

ylc395 avatar Jan 15 '24 03:01 ylc395

@jsonnull hello, would you check this PR?

ylc395 avatar Feb 01 '24 09:02 ylc395

BUMP, need it for esm

lucasrabiec avatar May 14 '24 11:05 lucasrabiec

Can this get pushed? I'm also running into this issue.

acolvin-h1 avatar Jul 03 '24 17:07 acolvin-h1

@jsonnull Hello, Seems like this repo is still active. Would you please check this out?

ylc395 avatar Aug 06 '24 08:08 ylc395

I can try and take a look at this. Been a bit busy, but this repo is still actively maintained and used by many.

JoeHartzell avatar Aug 06 '24 15:08 JoeHartzell

@ylc395 I have a set of changes coming soon to address issues folks are having using ESM. It's going to be a major version bump in the library, but going forward modules will have test coverage and examples.

In the meantime, you have a few options:

  • Use a bundler for your preload file. The electron docs recommend this, and before the changes to support ESM I have not supported using the library for preloads without a bundler. If you're self-imposing this constraint today, that is your decision.
  • Hand-write (copy+paste) a preload file. IMO this is the easiest option, and this is safe until the major version bump, at which point you would have to address breaking changes regardless.
  • Use pnpm patch or otherwise vendor a version of this library that is modified to your use-case.

jsonnull avatar Aug 06 '24 17:08 jsonnull