understanding-json-schema icon indicating copy to clipboard operation
understanding-json-schema copied to clipboard

PR build previews do not include PDF version

Open Relequestual opened this issue 4 years ago • 3 comments

It's unclear if we wish to continue to support the PDF version of this resource, especially if we plan to merge it into the main JSON Schema site repo. However, should we decide we DO want to, or someone from the community is willing, there may be some useful informatio regarding how we might achive this in the following gist.

https://gist.github.com/ridem/5e1608e771f7cfc9798d33c72903fb35

This relates specifically to needing texlive available to the build processor, Netlify.

Relequestual avatar Apr 27 '21 15:04 Relequestual

If it's a hassle, then it's not worth it. I wouldn't bother trying to get it working.

jdesrosiers avatar Apr 29 '21 19:04 jdesrosiers

It's probably more hastle than it's worth is my feeling, but I guess some people might like the "book"

Relequestual avatar May 17 '21 15:05 Relequestual

It turns out that the preview builds aren't working perfectly. The "Draft Specific" and "Language Specific" sections specifically don't render properly. Getting those issues working in local builds (#157) turned out to fix the pdf generation as well. I don't know how netlify works exactly but, what I figured out for #157 might be useful in getting those builds working properly.

For now, production deploy is going through Travis, so the minor rendering issues are not a big deal for deploy previews. But if we want to move off of Travis and use Netlify for production deployment, we'd have to solve the problem.

jdesrosiers avatar May 20 '21 02:05 jdesrosiers

With the release of the new JSON Schema website this issue is going to be closed as not planed.

benjagm avatar Nov 02 '23 13:11 benjagm