JsonApiDotNetCore icon indicating copy to clipboard operation
JsonApiDotNetCore copied to clipboard

Request meta tests boilerplate

Open mrmarcosmagalhaes opened this issue 5 months ago • 5 comments

Closes #1500

QUALITY CHECKLIST

  • [x] Changes implemented in code
  • [x] Complies with our contributing guidelines
  • [x] Adapted tests
  • [x] Documentation updated

mrmarcosmagalhaes avatar Jul 16 '25 09:07 mrmarcosmagalhaes

Thanks, this looks great!

I've changed the base of this PR, so that status checks run.

bkoelman avatar Jul 19 '25 09:07 bkoelman

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.21%. Comparing base (3cd643a) to head (8dc82d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1746      +/-   ##
==========================================
- Coverage   92.23%   92.21%   -0.02%     
==========================================
  Files         437      437              
  Lines       14866    14866              
  Branches     2451     2451              
==========================================
- Hits        13711    13709       -2     
- Misses        710      712       +2     
  Partials      445      445              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 19 '25 09:07 codecov[bot]

@mrmarcosmagalhaes, do you still want to complete the work on this PR? If not, please let me know, so I can pick up from here.

bkoelman avatar Dec 03 '25 01:12 bkoelman

Good morning

I want to finalize this pull request. Sorry for the late reply. I had another child and i didn't have so much time. Until to next weekend i will implement your suggestions 👌

Regards, Marcos Magalhães

A quarta, 3/12/2025, 01:54, Bart Koelman @.***> escreveu:

bkoelman left a comment (json-api-dotnet/JsonApiDotNetCore#1746) https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/1746#issuecomment-3604695538

@mrmarcosmagalhaes https://github.com/mrmarcosmagalhaes, do you still want to complete the work on this PR? If not, please let me know, so I can pick up from here.

— Reply to this email directly, view it on GitHub https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/1746#issuecomment-3604695538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOSMSAGDVHA64QHCUHPVWL37Y7FXAVCNFSM6AAAAACBUJV36GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBUGY4TKNJTHA . You are receiving this because you were mentioned.Message ID: @.***>

mrmarcosmagalhaes avatar Dec 08 '25 07:12 mrmarcosmagalhaes

Congratulations! Looking forward to your contribution.

bkoelman avatar Dec 09 '25 09:12 bkoelman