JsonApiDotNetCore icon indicating copy to clipboard operation
JsonApiDotNetCore copied to clipboard

Try .NET/EF 9 RC2

Open bkoelman opened this issue 1 year ago • 4 comments

Explores multi-targeting against .NET 9 with EF Core 9 pre-release versions. This PR is experimental and not intended to be merged.

Blocked by:

  • https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1841
  • https://github.com/NuGet/Home/issues/13855
  • ~https://github.com/dotnet/efcore/issues/34728~
  • ~https://youtrack.jetbrains.com/issue/RSRP-498478/Breaking-primary-constructors-with-readonly-field~
  • ~https://github.com/dotnet/roslyn-analyzers/issues/7421~

bkoelman avatar May 25 '24 07:05 bkoelman

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.73%. Comparing base (55f671c) to head (d7ff06d). Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/Examples/DapperExample/Program.cs 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1550   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         353      353           
  Lines       11492    11492           
  Branches     1888     1888           
=======================================
  Hits        10427    10427           
  Misses        696      696           
  Partials      369      369           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 25 '24 07:05 codecov[bot]

Hi - is there a preview Nuget of this anywhere we can try against our own code?

wayne-o avatar Oct 14 '24 09:10 wayne-o

I don't think there's a need for that. EF Core 9 targets .NET 8, so the current JADNC version should work already with EF Core 9 on both .NET 8 and 9.

bkoelman avatar Oct 14 '24 13:10 bkoelman

I've created #1619 to verify all tests are green when running on .NET 9 RC2 with EF Core 9 RC2, while still referencing JADNC that targets only .NET 8 and 6.

While there are breaking changes in the EF Core driver API (so you'll need matching versions for PostgreSQL, MySQL, SQL Server, etc.), it appears that JADNC itself is already compatible. This means we don't need to release a new version of JADNC when .NET 9 ships.

bkoelman avatar Oct 15 '24 00:10 bkoelman

Superseded by #1656. We currently have no need to multi-target the JsonApiDotNetCore library itself against .NET 9.

bkoelman avatar Dec 24 '24 09:12 bkoelman