James Socol
James Socol
OK I actually have a path forward here, 7 years later. It's another way to implement @jasonm's core idea of making flag buckets deterministic. - Let `p` be the percentage...
Here's what I'm planning to do, simplified a little: ```py3 if request.user.is_authenticated: if hasattr(request.user, 'get_waffle_id'): uid = str(request.user.get_waffle_id()) else: uid = str(request.user.pk) else: # check-and-set cookie uid = request.COOKIES['waffleid'] #...
I might not do the `get_waffle_id()` part. I was thinking about cases where the user primary key might not be string serializable, or where Waffle users might have some reason...
This is also going to break the `set_flag` utility that some folks have asked for and (presumably) used. It won't be possible to set a flag for an individual user...
Logging non-existent settings is a great idea! We can probably just log them to a `waffle` logger at a `WARNING` level and let folks configure/silence the logger if they want...
Since it's another breaking change, I'm putting it in 0.12 for now.
Honestly, I don't have a good idea of how to fix this. I have a couple of lousy ideas. The problem is that the prefix (`dwft_`) is user-configurable—in fact **it...
Flag interactions are complex and while both the in-admin help and the documentation need to be better, I don't think it's every going to be really possible to explain it...
Does this affect compatibility with 1.4esr or 1.5 at all? Changing the cache timeout seems like it would
+1 for deprecating this whole package but not necessarily to playdoh. If there are things that are more generic but nose-specific they could go into django-nose