vue-parallax-js icon indicating copy to clipboard operation
vue-parallax-js copied to clipboard

remove() method does not work

Open JacekZakowicz opened this issue 6 years ago • 0 comments

Hello,

I have found out that remove() method does not work properly. Currently it looks like this:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(el), 1)
      }
    }
  }

As we can see no elements are actually removed from the array. In order to make it work properly it should be:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(item), 1)
        break
      }
    }
  }

I would make a pull request but somehow can't succeed.

JacekZakowicz avatar Sep 27 '19 09:09 JacekZakowicz