go-artnet
go-artnet copied to clipboard
jsimonetti
ArtPollReply NodeReport - Pending PR #39
Pre-requisite: https://github.com/jsimonetti/go-artnet/pull/39
Bring NodeReport into spec
The array is a textual report of the Node’s operating status or operational errors. It is primarily intended for ‘engineering’ data rather than ‘end user’ data. The field is formatted as: “#xxxx [yyyy..] zzzzz…” xxxx is a hex status code as defined in Table 3. yyyy is a decimal counter that increments every time the Node sends an ArtPollResponse. This allows the controller to monitor event changes in the Node zzzz is an English text string defining the status. This is a fixed length field, although the string it contains can be shorter than the field.
Yes, I'll come back to this then.
Mostly unrelated, but I couldn't find another means to contact you: I recently built a fairly large installation using ArtNet and used this library. I got pressed for time and didn't condense many of my changes into PRs yet. I'll probably come back and do that, but I wanted to check which changes I should package up for PR based on how much you may want preserve the structure of the repo. Some of the changes are strictly functional/bug-fixes, other ones push for more idiomatic go, and some provide additional features. What types of changes are you open to? Just hoping to avoid putting effort into breaking up my changes only to get a rejected PR for stylistic/idealogical reasons.
Hi @jmbarzee ,
I am fully open to changes to this library. It is good to hear this has been useful for you!
Currently, I am not using this library, as I switched to a different (hardware) product to control my smarthome. So I have no objection to changes, if that means the usability and quality will go up.
We can always cut a release and warn people up front of breaking changes.
If you would like to contact outside this issue, I am open for that too. You are welcome to email me at my sign-off address.
