go-artnet icon indicating copy to clipboard operation
go-artnet copied to clipboard

Adds an option to change the listen-on address and exposes the UDP connection

Open bmurray opened this issue 1 year ago • 5 comments

This lets the caller set the IP and Port. Useful on multi-homed servers.

This also exposes the udp connection on a Node, in case one wants to send a raw DMX packet, or otherwise.

bmurray avatar Jan 29 '24 09:01 bmurray

Hi! Thank you for your contribution. Not all your commits contain a sign-off. Could you please sign-off on these? I dont mind if you squash everything.

jsimonetti avatar Jan 29 '24 10:01 jsimonetti

Sorry about that. Should be good now!

bmurray avatar Jan 29 '24 18:01 bmurray

@bmurray Unfortunately the commits are still not shown as signed. Did you add your signing key [email protected] to GitHub?

aklinkert avatar Jan 31 '24 08:01 aklinkert

I'm pretty new to signing so I didn't realize there was a GPG signing option too. Rather confusing. I was able to sign with a new GPG key. It says verified now, so I think its good.

bmurray avatar Feb 01 '24 00:02 bmurray

@bmurray Can you please resolve the conflicts?

aklinkert avatar Feb 01 '24 12:02 aklinkert