http-errors icon indicating copy to clipboard operation
http-errors copied to clipboard

Published 20 hours ago • verified publisher icon jshttp

Improved interoperability with ES6 classes

Open nathanlepori opened this issue 2 years ago • 4 comments

PR for #98

nathanlepori avatar Jun 21 '23 11:06 nathanlepori

Any updates on this?

nathanlepori avatar Nov 17 '23 21:11 nathanlepori

Sorry, it slipped through the cracks. Is it possible to get tests added for this? I can look into adding them too. Ideally es6 classes to make sure we don't break it in the future.

dougwilson avatar Nov 17 '23 21:11 dougwilson

Sure no problem. Whenever I have some time I will write a couple tests based on the use case that we encountered on our project

nathanlepori avatar Nov 18 '23 10:11 nathanlepori

@dougwilson it's done. I could only come up with one test since the change is very small and it's the only case where it broke (i.e. directly extending HttpError). Let me know if I should add something more

nathanlepori avatar Nov 18 '23 14:11 nathanlepori