Jacob Hoffman-Andrews

Results 400 comments of Jacob Hoffman-Andrews
trafficstars

I'll take a look! It looks like this would replace cbindgen; is that accurate? Is the goal to offer richer support for C++, or to provide a better developer experience...

You mention that we could avoid implementing `rustls_str` and `rustls_slice_bytes`. I see that cxx offers a C++ `rust::Str` https://cxx.rs/binding/str.html, but does it also offer a C equivalent? Do you know...

[Currently `rustls_str` is:](https://github.com/abetterinternet/crustls/blob/64d37f1c34915d5aaf78d6cadb4283f247e32ef2/src/crustls.h#L233-L236) ``` typedef struct rustls_str { const char *data; size_t len; } rustls_str; ``` I think asking C code to go through accessor methods like `rustls_str_data(rstr)` and `rustls_str_len(rstr)`...

> how can one configure a supported cipher without mentioning the tls protocol version? > how can one enable a specific protocol version without being aware which ciphers belong to...

It seems like this a relevant comment in lib/vtls/rustls.c in the curl repo: ``` /* * Connection has been established according to rustls. Set send/recv * handlers, and update the...

> * This check has to come last because is_handshaking starts out false, > * then becomes true when we first write data, then becomes false again > * once...

Hi @kaisq! Thanks for trying out rustls-ffi. Can you tell me a bit more about your application? It sounds like you have some Rust components and some C components, but...

Ah, thanks for the clarification! I think what we need is a new function/method to build a [rustls_certified_key](https://docs.rs/rustls-ffi/0.8.2/rustls_ffi/cipher/struct.rustls_certified_key.html) (the opaque FFI view onto a [rustls::CertifiedKey](https://docs.rs/rustls/0.20.2/rustls/sign/struct.CertifiedKey.html). Right now the only constructor...

> Basically, we'd add a new rustls_certified_key_build_dynamic to the impl rustls_certified_key block, which would pass in a couple callback functions that would perform the duties of the two functions declared...

I've moved this issue to the rustls-ffi repository. Here's the snippet from the linked apache.txt: ``` checking whether to enable mod_tls... checking dependencies checking for rustls... checking for user-provided rustls...