Jacob Hoffman-Andrews
Jacob Hoffman-Andrews
> we could do this for two cases, for chunked when the user also reads 0\r\n\r\n, and for content-length when the user reads the entire length. For chunked, if the...
I think I may have misunderstood what you are saying. I agree chunked transfer streams are reusable if the user reads all the way to EOF (which means the ChunkDecoder...
Yes, good point- possible if I had cmake installed, everything would work just fine, because mbedtls probably ships with the native code it needs to build. But even so -...
It honestly didn't occur to me that we could change it. The main thing going on in `into_string()` is reading, which produces `io::Error`. But of course, `ureq::error::Transport` can hold an...
I think this is a variant of #318. Presumably we get one or the other error depending on whether the server sends a close_notify vs closing the connection outright. Here's...
Here's the result of letting the above command run through the full list. Of 510 input hostnames, we get 479 output lines with SSL_ERROR_SYSCALL. I think that's sufficient to conclude...
I think this may also be related: https://github.com/ctz/rustls/issues/160
For reference, here's what `reqwest` does: `reqwest::Request` has ```rust impl TryFrom for Request where T: Into, ``` https://docs.rs/reqwest/latest/reqwest/struct.Request.html#impl-TryFrom%3CRequest%3CT%3E%3E And [`reqwest::Body`](https://docs.rs/reqwest/latest/reqwest/struct.Body.html) has these impls: ``` [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3C%26%27static%20str%3E) [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3CBody%3E) [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3CBytes%3E) [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3CFile%3E) [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3CResponse%3E) [From](https://docs.rs/reqwest/latest/reqwest/struct.Body.html#impl-From%3CString%3E)...
> In #351 we size limit bodies to 10MB, but into_string() will in practice for a short period hold both the original Vec and the String in memory pushing the...
> Not necessarily disagreeing, but what do you think about curl doing this mangling? I was surprised to learn about it! I'm going to go read some curl docs and...