Jacob Hoffman-Andrews

Results 408 comments of Jacob Hoffman-Andrews

> I would have replaced the current Reader type by adding the Seek bound. Part of our user-facing API is: ``` pub fn send(&mut self, reader: impl Read + 'static)...

On the flip side (a little off-topic but it's entertaining IMO), there are [some servers out there](https://github.com/golang/go/issues/31259) that will send you a response as soon as you connect, without even...

As of 2.1.0, `Request` does expose `url`, `request_url`, and `method`: https://docs.rs/ureq/2.1.0/ureq/struct.Request.html. Having a way to build a `Response` for use in a caching layer is a good idea. I think...

What do you think of doing `into_string()[..MY_OWN_LIMIT]`? That might be better for your use case, because it would read the whole response (up to the 10MB limit), which means the...

> For the optional configuration in Request, would that be for all responses (as in into_reader() will also be limited) or just for into_string()? I'm not sure! My inclination is...

At the HTTP protocol level, _something_ has to read the full response body before the TCP connection is ready to send connections on again. In ureq, that's done with into_reader,...

I'm not keen on adding an explicit `return_to_pool`, when we already have various functions that accomplish the same goal, like `into_string()`. I would rather make the API more obvious /...

That's a very helpful reference. Thank you!

We removed `Agent::set_cookie` here: https://github.com/algesten/ureq/commit/1f8bb532fee3ae290aaabfb085dbfefd14a03003 After discussion here: https://github.com/algesten/ureq/issues/203#issuecomment-716385310 The short version is: Agent is meant to be shared widely across your program, to maximize connection reuse. It uses internal...