bot icon indicating copy to clipboard operation
bot copied to clipboard

add feature to ignore old directory/file structure before certain version

Open PeterDaveHello opened this issue 11 years ago • 7 comments

Because the structure may be changed, we can't control or make sure the structure will be the same forever, once it changes, e.g. rename javascript to js, CI bot will not success and fail in all the after version, but that doesn't make sense, we still need a human begin to check the CI message, I think we should support this feature to ignore the old structure before a certain version, so it won't make all the after version not pass CI bot, and the version may be set in info.ini

PeterDaveHello avatar Jun 29 '14 06:06 PeterDaveHello

for example, #996, #981, #980, #872, #865, #847 ...

PeterDaveHello avatar Jun 29 '14 06:06 PeterDaveHello

This will be fixed whenever the api decides to support multiple mainfiles. For now its now possible

megawac avatar Jun 30 '14 04:06 megawac

but not only the main file will be changed, but the the other file and directory structure may be changed

PeterDaveHello avatar Jun 30 '14 09:06 PeterDaveHello

Useful info to know between versions no? It only checks the closest version anyway

Sent from my HTC

----- Reply message ----- From: "Peter Dave Hello" [email protected] To: "jsdelivr/bot" [email protected] Cc: "Graeme Yeates" [email protected] Subject: [bot] add feature to ignore old directory/file structure before certain version (#19) Date: Mon, Jun 30, 2014 5:42 AM but not only the main file will be changed, but the the other file and directory structure may be changed

— Reply to this email directly or view it on GitHub.

megawac avatar Jun 30 '14 13:06 megawac

not really the closest version, you can take a look at jsdelivr/jsdelivr#847 as a example

PeterDaveHello avatar Jun 30 '14 14:06 PeterDaveHello

@PeterDaveHello how is that not the closest semver versions https://github.com/PeterDaveHello/jsdelivr/tree/e5884469aa01b4cc24a56eba3936b716e49ad69d/files/tablesorter. Its one minor release iteration. The bot is just to help contribs and collabs spot potential sources of errors and allow them to use their own judgement

2.16.4 -> 2.17.0 One minor cycle

megawac avatar Jun 30 '14 15:06 megawac

sorry that I got misunderstanding, I mean here:

Looks like the info.ini has a few problems
Where is the tablesorter's mainfile (js/jquery.tablesorter.min.js) in v-2.10.8
Where is the tablesorter's mainfile (js/jquery.tablesorter.min.js) in v-2.0.5b
Where is the tablesorter's mainfile (js/jquery.tablesorter.min.js) in v-2.0.3

not only the closest version @@

PeterDaveHello avatar Jun 30 '14 15:06 PeterDaveHello