Jonathan Schwender

Results 212 comments of Jonathan Schwender

Relevant Rust guide: https://doc.rust-lang.org/rustc/linker-plugin-lto.html The main requirement is that we ensure that clang and Rust use the same LLVM version, otherwise we will get errors during LTO. Perhaps we could...

@Taym95 Thanks for the interest! I mostly test on real hardware, but I've also used the HarmonyOS emulator to test my changes. However, that emulator is not publicly available yet...

During review of #32494 it was explicitly requested [to keep the warning enabled](https://github.com/servo/servo/pull/32494#discussion_r1639773126). CC @sagudev I think the idea here is to take a conservative approach, and first be very...

Probably the labels should be removed again - I guess I shouldn't have chosen the `Feature` template.

> This is done now. Thanks! I'm a bit confused - How exactly is this signing off enforced now? I don't see anything related in the last 3 commits on...

> Probably! In fact, by default, tracing installs a logger that catches any logging via log and [turns it into tracing events](https://crates.io/crates/tracing-log). We’ll need to rework our inter-process crash logging,...

While Choco is available by default on GitHub actions, it's not pre installed on regular windows installations. Winget on the other hand is pre installed on win 11 now.

@mrobinson I saw that you previously [mentioned that choco is not used in CI](https://github.com/servo/servo/issues/32342#issuecomment-2124885906). Is that not the case anymore, or am I missing some context?

I'm not confident that the current PR is "production-ready". I haven't tested choco myself, so I don't know how many points also affect choco, but some things to still consider...

Do we still want to support bootstrap in CI? If yes, then we can't run the llvm install in interactive mode (unless we individually check if a package is installed...