bootstrap-modal icon indicating copy to clipboard operation
bootstrap-modal copied to clipboard

Removed white background to be fully compliant with Bootstrap.

Open diosney opened this issue 11 years ago • 3 comments
trafficstars

Fixes #225

diosney avatar Mar 14 '14 17:03 diosney

This was an intended design change and has been like this since release. Since this plugin was meant to largely address the stacking modal issue, I believe that the white background works best. However this is a personal preference, so I will leave this PR open. If there is more support for reverting the colour back to black, I will consider changing it.

jschr avatar Mar 15 '14 15:03 jschr

Ok.

Since this plugin was meant to largely address the stacking modal issue, I believe that the white > background works best.

What do you mean with that? I reverted to use a black/grayish background and the color stacking works perfect for me (they decrease in opacity as more modals are stacked, darkening the last opened modal).

diosney avatar Mar 17 '14 17:03 diosney

It definitely works functionally. It was personal preference from the beginning since bootstrap is predominantly used with a light theme. I believed it was smoother having the page fade to white as opposed to black.

jschr avatar Mar 17 '14 17:03 jschr