Joe Schafer

Results 78 comments of Joe Schafer

Thanks for the detailed report. I can reproduce. The error is that pgtype.Numeric cannot be `Set` from another pgtype.Numeric instance. This doesn't occur with other numeric types because they're mapped...

So, we're a bit stuck. Here's the options: - We can't use `pgtype.Numeric` because pgtype.Numeric.Set doesn't support being set from another instance of pgtype.Numeric. - `--gotype numeric=*string` doesn't work because...

I added an example of how to make this work with a real Decimal type in 7f87888. The main trick is to register the data type on the Querier: ```go...

Thanks for the solid write up. I also want this functionality. Technically, it’s not terribly challenging. The main design problem is how to handle edge cases. I think behavior is...

> If you could point me in the right direction (and if you are interested) @jschaf then I could take a shot at writing a PR with this functionality. Sure,...

I've been following the beta threads closely. I'd like to upgrade but looks like a pretty decent lift. I'll wait until it's released before planning the migration.

Nice, detailed writeup! Agreed that we probably need multi-line with this change. Couple tweaks: - For ease of parsing, I'm in favor of using a pggen prefix to identify metadata...

> Do we allow "comment" lines without the pggen: prefix in-between or after the lines with the prefix? I think not. Easier to start strict and allow flexibility later. >...

All right, my guess is that it was a separate module that was removed, but the interface code was never deleted. I submit a pull request to delete it.

I hit this trying to pass the protobuf conformance tests using protobuf.js. I think `uint32` is buggy and advances the read position more than necessary. Test case: Required.Proto3.ProtobufInput.RepeatedScalarSelectsLast.BOOL.ProtobufOutput Hex: `6800680168ffffffffffffffffff0168cec2f10568808080802068ffffffffffffffff7f6880808080808080808001`...