jquery-ui icon indicating copy to clipboard operation
jquery-ui copied to clipboard

Resizable: Fix issue with border-box

Open mcanepa opened this issue 4 years ago • 7 comments

fixes #1979

mcanepa avatar Nov 09 '21 17:11 mcanepa

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Matías Cánepa (5101f17d7c311594fc9ae83f4bc0a4dc157fc081)

We had broken CI for a while. Please rebase to the latest main so that GitHub Actions run on the PR.

We'll also need unit tests for the change and I'll need some time to understand what's exactly going on here; although, if you could add comments on GitHub explaining the code changes, that'd speed things up.

mgol avatar Dec 02 '21 18:12 mgol

If you're interested in finishing this, there are some existing autoResize tests in tests/unit/resizable/options.js, you'd need to add a new test there.

mgol avatar Jan 05 '22 11:01 mgol

I'll try my best...

This will be my first encounter with a unit test so any help from anyone it would be very much appreciated

mcanepa avatar Jan 05 '22 14:01 mcanepa

It's best to look at existing tests and do something similar. Of course, feel free to ask questions.

mgol avatar Jan 05 '22 15:01 mgol

@mgol just added a test. I hope it's ok!

mcanepa avatar Jan 30 '22 08:01 mcanepa

hello @mgol @fnagel

Any chance for this issue to be reviewed?

mcanepa avatar Jul 30 '22 20:07 mcanepa

Landed, thanks!

mgol avatar Oct 10 '22 09:10 mgol