Resizable: Fix issue with border-box
fixes #1979
The committers are authorized under a signed CLA.
- :white_check_mark: Matías Cánepa (5101f17d7c311594fc9ae83f4bc0a4dc157fc081)
We had broken CI for a while. Please rebase to the latest main so that GitHub Actions run on the PR.
We'll also need unit tests for the change and I'll need some time to understand what's exactly going on here; although, if you could add comments on GitHub explaining the code changes, that'd speed things up.
If you're interested in finishing this, there are some existing autoResize tests in tests/unit/resizable/options.js, you'd need to add a new test there.
I'll try my best...
This will be my first encounter with a unit test so any help from anyone it would be very much appreciated
It's best to look at existing tests and do something similar. Of course, feel free to ask questions.
@mgol just added a test. I hope it's ok!
hello @mgol @fnagel
Any chance for this issue to be reviewed?
Landed, thanks!