jquery-ui icon indicating copy to clipboard operation
jquery-ui copied to clipboard

:focusable incorrectly requires tabindex on details and summary elements

Open bbenjamin opened this issue 6 years ago • 4 comments

I noticed this when opening a dialog with <details> elements that

contained no interactive elements other than <summary>. Was not followed by any other interactive elements. I was unable to access <details> with tab navigation as the focus was trapped at what it believed to be the last focusable element. This is addressed by adding details and summary to the list of elements $.ui.focusable assumes tabbable.

bbenjamin avatar Mar 15 '19 12:03 bbenjamin

@bbenjamin can you answer the question from @fuzzbomb ?

dmethvin avatar Jul 31 '19 23:07 dmethvin

@dmethvin - @fuzzbomb was correct, only summary is required. The PR was updated shortly after that based on his feedback. Looks like I neglected to follow that up with a comment here.

In case it's of use to people with a similar problem - After realizing jQueryUI hadn't had a commit since 2017 I proposed an alternate solution for its use in Drupal https://www.drupal.org/project/drupal/issues/3038336 - the patch there provides the overrides necessary to correct this issue without having to alter jQueryUI.

bbenjamin avatar Aug 01 '19 00:08 bbenjamin

Thank you for the quick reply! We're trying to get a little love started here for jQuery UI, mainly bug fixes and compat with the latest jQuery version. This is a good one to add.

dmethvin avatar Aug 01 '19 00:08 dmethvin

This change requires a test as well.

Sorry for the late reply but I'm not really in the UI team, although I have commit access. If you're still interested in getting it landed, feel free to ping me when a test is added.

mgol avatar Dec 08 '19 22:12 mgol