Jiaping(JP) Zhang
Jiaping(JP) Zhang
Sometimes I found the same issue as well. This PR #5066 might help a bit in some cases.
It would be nice to also add jina's `annlite` for the vector store option as well.
I found the `score_threshold` also filters out the most relevant doc for the FAISS vectorstore. I think there are still bugs with this refactoring changes. ` First, the `FAISS.similarity_search_with_score` /`similarity_search_with_score_by_vector`...
I believe this feature provides practical values. Can I get a review on this one? @hwchase17 @dev2049
> i think we need just better documentation around conversational retrieval chains in general I have updated the notebook to show how to set `question_generator` as None and use a...
Hoping this can get merged soon since I need this patch for a work project! @hwchase17 @dev2049 any feedback?
@dev2049 @hwchase17 can you take a look at this PR? Sorry for chasing..
> @jpzhangvincent It is again :( Could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks! @leo-gan I believe I...
@leo-gan I believe I had resolved the test issues.. please review again and feel free to make code changes directly!
So any update on this PR? Thanks. - @leo-gan @baskaryan