feed icon indicating copy to clipboard operation
feed copied to clipboard

"docs field in rss2 is hard coded to http://blogs.law.harvard.edu/tech/rss

Open ToddWork opened this issue 6 years ago • 4 comments

Describe the bug When generating an RSS version 2 feed the "docs" field is hard coded to http://blogs.law.harvard.edu/tech/rss and cannot be overridden by config parameters.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Actual behavior A clear and concise description of what is the actual outcome.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • NodeJS:
  • TypeScript:
  • npm/yarn:
  • feed:

Additional context Add any other context about the problem here.

ToddWork avatar Dec 12 '18 03:12 ToddWork

@discoscott What do you want to replace this with?

jpmonette avatar Dec 16 '18 17:12 jpmonette

This is a really minor issue, but I thought I would bring it up...

I would suggest we make it an optional field that gets set and included only if it is passed in the config parameters.

ToddWork avatar Dec 17 '18 15:12 ToddWork

Yes, please make this optional.

tcurdt avatar Feb 27 '19 21:02 tcurdt

I've created a PR to address this: https://github.com/jpmonette/feed/pull/97

sonniesedge avatar Aug 07 '19 14:08 sonniesedge