emacs-crystal-mode icon indicating copy to clipboard operation
emacs-crystal-mode copied to clipboard

Won't this be updated anymore?

Open tbrand opened this issue 8 years ago • 12 comments
trafficstars

I love emacs and crystal. I really disappointed when I knew this repository is not updated recently since there are still bugs especially when I write macros.

Here is a wrong indenting pattern which I faced.

{% if ok = true %}
{{ok}} # should be indented
{% end %}
{% if true %}
  func0
{% else %}
func1 # should be indented
{% end %}
{% if true %}
{% end %}
  {% if true %} # wrong indenting
  {% end %}

It seems that @dotmilk and @TechMagister are still developing in forked repository. But the bugs above are still remaining.

Have anyone solved this bugs? (The lisp syntax is not readable for me...)

tbrand avatar Jan 05 '17 12:01 tbrand

Well, I suppose you could fork the code and make improvements. After all, that part of what github is about.

rocky avatar Jan 06 '17 00:01 rocky

I will struggle with the elisp.

tbrand avatar Jan 06 '17 01:01 tbrand

That's the spirit!

rocky avatar Jan 06 '17 02:01 rocky

@tbrand I found a way to fix it, but elisp is not my favorite language, so give me feedback if you find some bugs :)

TechMagister avatar Jan 06 '17 10:01 TechMagister

Thanks a lot @TechMagister !!:tada: I will use it!

This works very fine! Thanks again! :)

tbrand avatar Jan 06 '17 11:01 tbrand

I think a problem here is everyone forking stuff and working independently. Merging upstream isn't working so we need to agree on another collective upstream. https://github.com/dotmilk/emacs-crystal-mode seems like a good candidate.

RX14 avatar Jan 07 '17 17:01 RX14

Good idea ! @dotmilk what do you think ?

TechMagister avatar Jan 08 '17 07:01 TechMagister

Agree! Additionally, may be the repository should be detached from the original. Because we cannot post issues and PRs to forked repository.

tbrand avatar Jan 08 '17 09:01 tbrand

@tbrand You can turn on issues for a fork, and you can always send PRs.

RX14 avatar Jan 08 '17 10:01 RX14

I have turned on issues on my fork

dotmilk avatar Jan 08 '17 21:01 dotmilk

Make sure to watch @dotmilk's repo if you're interested in fixing bugs.

RX14 avatar Jan 08 '17 21:01 RX14

I got it! Thanks for all!

tbrand avatar Jan 09 '17 03:01 tbrand