JP DeVries

Results 186 comments of JP DeVries

@nicboyde thanks for reporting this. Gallery development has been moved to https://github.com/modxcms/Gallery/

Is this hardcoded for just TinyMCE or expected to work in general with RTEs?

Gallery is now managed over at modxcms/Gallery. and am wondering if you could help me understand how to test it. Just not sure how to use the new feature. https://github.com/modxcms/Gallery/tree/media-sources

Thanks for this! Duplicate of #82

Thanks for this @Bournwog. Are there any specific tests that come to mind to make sure this doesn't introduce any new issues? I've got this merged into a testing branch...

@Bournwog why not use `$this->modx->parser` instead of calling `$this->modx->getParser()` twice?

@bertoost i'm talking about this in the PR ``` php // parse all cacheable tags first $this->modx->getParser()->processElementTags('', $str, true, false, '[[', ']]', array(), 10); // parse all non-cacheable and remove...

i guess i don't understand the need to call `$this->modx->getParser();` since it wasn't doing so before. is it to ensure the parser is loaded?

Got this merged in the modxcms/FormIt fork https://github.com/modxcms/FormIt/commit/44edb50fb3b5b87781f1b1e827956017fe2ec340

I'm having a hard time understanding the use case for this one