react-scrolllock icon indicating copy to clipboard operation
react-scrolllock copied to clipboard

Components are re-mounted when isActive changes

Open eirikurn opened this issue 6 years ago • 1 comments

Since they move between being direct descendants of ScrollLock, and children of SheetLock:

https://github.com/jossmac/react-scrolllock/blob/master/src/ScrollLock.js#L52

This is bad for performance and breaks state and transitions.

eirikurn avatar Feb 14 '19 00:02 eirikurn

I agree, this is a huge issue and makes everything look broken.

joebentaylor avatar Apr 15 '19 22:04 joebentaylor