Josh W Lewis

Results 32 comments of Josh W Lewis

Hey, not exactly sure what you are getting at. You should be able to add and subtract temperatures without issue. A delta temperature is still a temperature, a delta speed...

I think I see what you mean. These feel inconsistent: ```ruby (Unitwise(100, "°C") - Unitwise(3, "°C")) > Unitwise(98, "°C") # => false (Unitwise(100, "°C") - Unitwise(3, "K")) > Unitwise(98, "°C")...

These files are sourced from the UCUM project - so it's probably best to take this issue upstream. It looks like UCUM is on GitHub now(!), so maybe you could...

Hmm, I see. Thanks for investigating. This sounds like the same issue described in #26. Do all the tests pass with your proposed solution? My guess is that the `simpleton_stop`...

Ok, cool. I think this would be good to bring in. Can you open a PR with these changes, but make sure that the `simpleton_stop` rule includes all the characters...

@phlegx, thanks for the report. This certainly looks like a bug. `dar` should be something we can parse. We should be able to parse `da` as the same unit, but...

On the `#to_hash` part, I think you are correct. I'll update that in a future release. On the person unit, that seems a little weird since it's just a count...

As to the first, yes, you have to be explicit. `Unitwise(3, 'foot').to_meter` would probably be what you want. Unitwise doesn't have preferred unit mappings, though this is probably a reasonable...

I agree, UCUM (and by extension Unitwise) is built to encompass a huge scope of units. That is obviously useful for say fluid dynamics and heat transfer. There are probably...

Thanks @pinkynrg. This looks fine, but tests are still failing. Can you add `sqrt` and fix the other method names [here](https://github.com/joshwlewis/unitwise/blob/c76d203bf665676bb8b151ffc51d0894d88bbaa9/test/unitwise/functional_test.rb#L5)?