quake-cli-tools icon indicating copy to clipboard operation
quake-cli-tools copied to clipboard

Improve wad texture handling

Open DrLex0 opened this issue 1 year ago • 6 comments

Fix for issue #37, and actually also #2 (if the user maps their input images to the Quake palette and ensures none of the pixels have fullbright colors if undesired).

For the wad tool:

  • Option -r to skip RGB conversion for images that already are indexed color (obviously they must use the Quake palette). Especially useful to avoid that pixels unexpectedly become fullbright.
  • Option -s to use smooth resizing when generating mipmaps.
  • Option -S to use optimal scaling depending on presence of fullbright pixels or not.

Default behavior remains the same, but in most cases it will be recommended to run wad with -rS arguments.

DrLex0 avatar Nov 24 '24 00:11 DrLex0

@joshuaskelly Any chance to merge this?

jonathanlinat avatar Nov 30 '24 20:11 jonathanlinat

Can the parameters be given full names too? e.g., --no-convert, --smooth-resize, or something?

hemebond avatar Dec 01 '24 01:12 hemebond

Can the parameters be given full names too? e.g., --no-convert, --smooth-resize, or something?

  • -r = --raw-indexed
  • -s = --smooth-mip
  • -S = --smart-mip

DrLex0 avatar Dec 03 '24 20:12 DrLex0

Can the parameters be given full names too? e.g., --no-convert, --smooth-resize, or something?

* `-r` = `--raw-indexed`
* `-s` = `--smooth-mip`
* `-S` = `--smart-mip`

That’s exactly @hemebond's point. Having both -s and -S might be confusing. How about adding the full names as well for clarity?

jonathanlinat avatar Dec 03 '24 20:12 jonathanlinat

@jonathanlinat They have been added, these are the new long parameter names that correspond to the short ones (I have also added long parameters for type and quiet).

DrLex0 avatar Dec 04 '24 12:12 DrLex0

You are right. I didn't see the commit. Nice addition @DrLex0 🙏🏻

jonathanlinat avatar Dec 04 '24 12:12 jonathanlinat