quake-cli-tools icon indicating copy to clipboard operation
quake-cli-tools copied to clipboard

Published 20 hours ago • verified publisher icon joshuaskelly

Chore request: Rename the existing image/sprite tools

Open jonathanlinat opened this issue 2 years ago • 4 comments

Hi Joshua! 👋

I've been looking into our tool names and thought of a more accurate naming scheme:

  • image2spr to gif2spr
  • spr2image to spr2gif

Both tools currently work exclusively with GIF files. Adopting these names would reflect their actual functionality and help us establish a clearer naming convention across our toolkit. Sounds like a win-win, right? 🚀

jonathanlinat avatar Nov 21 '23 02:11 jonathanlinat

Incorrect. They support all formats supported by Pillow. https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html

In theory you could create an spr from a .PSD, or convert an spr into a .PDF!

joshuaskelly avatar Nov 21 '23 05:11 joshuaskelly

Understood. So, those scripts must be adjusted based on your explanation. They are only referencing the GIF format in their codebase.

jonathanlinat avatar Nov 21 '23 06:11 jonathanlinat

The code is actually fine. I created PNG and PDF versions of s_bubble.spr. What bit of code are you referencing?

joshuaskelly avatar Nov 21 '23 21:11 joshuaskelly

Yep, you are absolutely right. The code is OK, but the instructions are not. There are only references to the GIF format.

image

As you can see, I do believe these need to be adjusted to ensure the developers and mappers understand that this script is working with all the formats provided by Pillow, as you mentioned.

Does that make sense?

jonathanlinat avatar Nov 21 '23 21:11 jonathanlinat