Josh Temple

Results 28 comments of Josh Temple
trafficstars

Thanks @ryan-duve for the example! I understand this issue better now and I'll get a fix pushed out in the next few days where we don't mutate that input directly.

I'm fairly new to SQLAlchemy, but I've been testing SQLAlchemy 2.0, and I've noticed that the new declarative model definitions result in model instances where `dataclasses.is_dataclass(obj) == True`, which has...

Hey @d-swift, can you update to the release candidate for the next version of Spectacles and try again? ``` pip install spectacles==2.3.0rc3 ```

I believe this is a duplicate of #610.

Thanks @d-swift! Looks like we can't always rely on those content objects having a title. I wish we had better guarantees from the Looker API about this sort of thing,...

@DylanBaker, [we relaxed the content type](https://github.com/spectacles-ci/spectacles/blob/master/spectacles/validators/content.py#L113-L122) to allow all other possible content types. It's possible some of these just don't have titles (we would have been skipping them and warning...

Thanks! That's interesting, I certainly see why kwargs only would be more readable in cases with large number of properties. My preference is that style like this is set and...

@yuchenshi I'm still encountering this issue in v11.15.0 in Docker. Adding the `logging` section referenced above to my `firebase.json` does fix the problem.

Thanks for your patience on this one. I've released version `1.3.1` which has this change. Please give it a try and let me know if it fixes your issue.

Hey @mariana-s-fernandes! I think this is a great idea! This isn't something we're likely to prioritize soon, but I think it would be a pretty straightforward change to make if...