Joshua Sedler

Results 21 comments of Joshua Sedler

For some reason, `printf "$CONTAINER_NAME_OR_ID" | xxd -p` lead to two different outcomes depending on the distro: - Under Windows + WSL2 (with Ubuntu installed) using zsh, it works as...

Thanks, @tyler36! Yea, I probably skipped on "xxd" too fast, Never the less I'll rather use `code --folder-uri vscode-remote://attached-container+$(printf "$CONTAINER_NAME_OR_ID" | od -A n -t x1 | sed 's/ *//g'...

@tuunit, thanks for sharing! You say, that you start a devcontainer through "devcontainer up" and attach vscode to it. Do you know if the devcontainer cli can also take a...

@tuunit, sorry not very well worded, I updated my comment. Basically, what I mean is, that an attached vscode supports a [subset of devcontainer.json properties](https://code.visualstudio.com/docs/devcontainers/attach-container#_attached-container-configuration-files). So I basically want to...

Thanks a lot @tuunit! That sounds great! 🎉 I thought that part was script specific! So thanks for the clear up!

Ok, https://github.com/microsoft/vscode-remote-release/issues/5278#issuecomment-1785723387, doesn't solve this issue's problem yet. `devcontainers/cli` will always create its own devcontainer, no matter what. As @tuunit already said in his comment: >Meaning if a devcontainer defined...

@fabianwennink well done! Very clear and well documented code! @JPustkuchen and me just discussed the changes internally and only found a couple of small issues here and there while reviewing...

Looks awesome @Eugeny! Thanks for sharing and great work. 👍

I'd say so! Couldn't find any others.

Yes, this is also confirmed by Google Lighthouse: > Avoid serving legacy JavaScript to modern browsers Potential savings of 13 KiB > > Polyfills and transforms enable legacy browsers to...