Josh Puetz

Results 29 comments of Josh Puetz

This is great @fdocr! What would the effort look like to re-enable CORS on the API?

I found their doc on migrating from v3.x to v4: https://github.com/fnando/i18n-js/blob/main/MIGRATING_FROM_V3_TO_V4.md

I gave this upgrade a shot and failed HARD. I _think_ what needs to be done is. Buildkite reports an error in `locale.js`: ```bash ERROR in ./app/javascript/utilities/locale.js 1:111-115 --   |...

@pkfrank I'm a little unclear on how exactly this works: can you explain the desired calculation? (also tagging @amywtlin)

@maestromac @aitchiss Looks like this is ready for final review!

Point of clarification: this kind of 'pushing' data from a system is known as a [webhook](https://en.wikipedia.org/wiki/Webhook) not an API.

> FYI this doesn't affect the work we want to achieve with the Reactions API, i.e. we can work on all of these in parallel if we want to. Eh,...

Flipping this back to draft: it doesn't make sense to merge this until https://github.com/forem/forem-docs/pull/89 is merged (which itself depends on https://github.com/forem/forem/pull/18213)

Closing in favor of the solution in https://github.com/forem/forem/pull/18213

> @joshpuetz Are we looking to wrap this up this week Or is this a backlog item? Clarified with @mirie that this is a longer term task, not necessary for...