tui-widgets
tui-widgets copied to clipboard
chore: Make ratatui optional on tui-popups (Breaking / Help Wanted
Rely on ratatui-core types mainly except for the interaction with crossterm.
The goal here was to remove the reliance on the unstable WidgetRef and StatefulWidgetRef traits, which are in Ratatui, and replace it with the stable Widget/StatefulWidget traits in Ratatui-core.
I haven't found a way (yet) to make this work for &W: Widget instead of W: Widget + Clone. Leaving this open a bit for anyone that wants to give feedback on the change / explore whether this is possible to fix.
This is the call that needs to work (render the body widget of the popup. https://github.com/joshka/tui-widgets/blob/83e45dbb31566ade6b323d05820c711561a1a46c/tui-popup/src/popup.rs#L147
Codecov Report
Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
Project coverage is 73.53%. Comparing base (
83e45db) to head (b73e779).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| tui-popup/src/known_size_wrapper.rs | 83.33% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 73.34% 73.53% +0.18%
==========================================
Files 14 14
Lines 2465 2441 -24
==========================================
- Hits 1808 1795 -13
+ Misses 657 646 -11
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.