Josh Goebel

Results 1720 comments of Josh Goebel

https://github.com/wren-lang/wren/commit/2a1499b04bc65853fdf71db2126e716168d4c5ae Look's like Bob's work in 2019. Any idea/memory on why we're masking that high bit in the first place? CC @munificent

Yeah I was trying to follow the existing established pattern for such things. A better solution might be what you suggest or just replacing the ASSERT in `printError` with a...

> Ideally, we'd use `snprintf()`, but that's not available in standard C++98. Ah...

Ping. Can I do anything further to expedite this? As far as I'm aware this is a valid fix that uses the same approach already put forward in the codebase...

> One thing is it doesn't mention why the length was doubled in the comments I added a mention of why. > is it an issue you're running into very...

> It will break any application that embeds Wren. It would also in many cases only be a 1 or 2 line change, no? Requiring someone to update their `WrenBindForeignMethodFn`...

Is releasing a handle re-entrant? If your C code just kept a global reference to the VM then you could free it easily during finalize, yes? It might be more...

https://github.com/sverrirs/jekyll-paginate-v2/blob/master/README-GENERATOR.md#renaming-pagination-file-names Seems this works out of the box now, perhaps your config is setting `indexpage` when it should be leaving it nil?

Is the heredoc syntax itself supported though?