Josh Goebel
Josh Goebel
> Single-quotes in Haskell are commonly mishandled by highlighters because of this complexity. Can they [all these different cases] be detected unambiguously with forward-looking regex only, or would we need...
So it sounds like if we just consume identifiers first (to prevent `'` inside of them from triggering character literals)... then consume character literals... (our matcher engine does match regex...
No, that's double quoted. https://github.com/highlightjs/highlight.js/blob/1a258a3e72dce8b6534e28a741cfcd7d813463dd/src/lib/modes.js#L51 We match single quotes in only 3 places I see: - `CONSTRUCTOR` - inherit from `TITLE_MODE` in two places The latter is probably already intended...
To handle JUST character literals though (as this issue was opened for) we'd just need a rule with a solid regex that could match characters: ``` { scope: "string.char", match:...
@AusCyberman Still interested in helping out? trying to figure out what we might be able to get into the 11.5 release.
> . I can't seem to find the package.json contents that have been shipped on npm Nor will you, they are auto-generated at build time. See `build_node.js`, line ~104. ---...
Good first issue IF someone is familiar with TypeScript's nodenext resolution and export maps in general.
We do not really desire to have separate ESM/CJS type files... (doubly so when we know CJS is on it's way out in the future anyways) We only took control...
> testing your types If they are auto-generated from source, what would you be testing? > If you're not generating your types from your js (which ts does support) Related...
> which may be enough to muddle through What would be the potential problems? We improved our CJS/ESM support a while back to make it more robust, ie CJS now...