reveal-hugo icon indicating copy to clipboard operation
reveal-hugo copied to clipboard

Turning reveal-hugo theme into a hugo module

Open deining opened this issue 3 years ago • 1 comments

This PR turns the reveal-hugo theme into a hugo module. With gitand go installed, preview of the userguide theme is now as easy as:

git clone https://github,com/dzello/reveal-hugo
cd exampleSIte
hugo server

The successful netlify preview for this PR proves that this approach is valid.

Copying/cloning the theme in the themes folder is still possible of course.

I amended instructions on how to use theme as hugo module with new and existing sites to README.md. Also, I added instructions on how to update the theme when used as hugo module (via hugo mod get -u github,com/dzello/reveal-hugo).

I hope you like the idea of using reveal-hugo as hugo module.

deining avatar Feb 24 '22 00:02 deining

Thanks @deining! I'll set aside a few minutes to review this week. I need to learn more about hugo modules but it seems like a sensible approach.

joshed-io avatar Feb 28 '22 08:02 joshed-io

This change also suggests that the repository starts tagging releases as valid semantic versions with the v prefix (i.e. v0.1.0). Although tagging is not strictly necessary to enable hugo modules, it makes it clearer for consumers when a new feature or bug fix is introduced in the theme.

davidovich avatar Dec 29 '22 00:12 davidovich

Thanks @deining! (...) I need to learn more about hugo modules but it seems like a sensible approach.

I updated my PR so that we now use HEAD of repo as module's version. Any chance to see that reviewed soon? Thanks in advance.

deining avatar Dec 29 '22 13:12 deining

Thanks for your review comments, which are addressed now. Looking forward to see this PR merged soon.

deining avatar Dec 31 '22 09:12 deining

@deining @davidovich Thank you! 🙏

joshed-io avatar Jan 09 '23 09:01 joshed-io