OnlineStats.jl icon indicating copy to clipboard operation
OnlineStats.jl copied to clipboard

when fit!-ing a Group to a NamedTuple, the names are ignored

Open schlichtanders opened this issue 1 year ago • 2 comments
trafficstars

using OnlineStats
o = Group(hi = Mean(), b = Counter())
fit!(o, [(b = 5, hi = 1)])

returns

Group
├─ Mean: n=1 | value=5.0
└─ Counter: n=1 | value=1

This is very confusing. If names are given on both sides, on definition of the Monoid and on the data, then it is at least for me intuitive if the data would be matched to the aggregators by names.

schlichtanders avatar Mar 08 '24 08:03 schlichtanders

fit!-ing is based on iteration: https://joshday.github.io/OnlineStats.jl/latest/howfitworks/

This is a good "OnlineStats 2.0" feature, but probably too much of a breaking change for now.

joshday avatar Mar 08 '24 21:03 joshday

I guess the breaking part is that currently using entirely different keys still works.

schlichtanders avatar Mar 09 '24 08:03 schlichtanders