Bean

Results 57 comments of Bean
trafficstars

> > So With commit [c68cc9b](https://github.com/josdejong/workerpool/commit/c68cc9b7ab2f57bddabeed9bcd6368111971abef) I have been able to get `Pool should timeout a task` to complete tear down > > This is a tough problem 😅 ....

> I checked out the latest version of the PR, running on node 20.17.0, Windows 11. I exect though that that doesn't make a difference. When running `npm test`, it...

@josdejong After reading [mocha hook docs](https://mochajs.org/#migrating-tests-to-use-root-hook-plugins) I was curious on the use of `after` since it is a global cleanup hook that runs once per test suite. I have modified...

> Thanks for your updates. Running the latest version of this PR on my Windows machine indeed works and all tests pass. > > However, I don't think that this...

@josdejong After tweaking the `finally` implementation to not return itself on either `resolve` or `reject` of the internal promise wrapper we now seem to have a passing test per https://github.com/josdejong/workerpool/pull/448#issuecomment-2333598456....

> Ok I've now merge #470. Can you update the PR to the latest version of the `master` branch with updated `Promise.finally`? Merged in,I was thinking the return in the...

> Is the volume a blocker to getting this PR merged? The container used in this PR was published as a test. But does provide some improvements to CI times...