Josh Berry

Results 311 comments of Josh Berry

Thanks! We're already on 1.34, so I'm gong to close this. Sorry we seem to have missed it earlier, I'm not sure why this fell through the cracks.

I think the JSON output includes everything we can meaningfully provide. The latest version of Versioning does not include binary checksums etc., just the build ID. But if something is...

I don't think the dev-server is intended to be run continuously as a service—it is ephemeral and loses state on every restart. I'm curious how it would help to have...

Seems like this works in the embedded server now: ``` ❯ grpcurl -plaintext localhost:7233 list grpc.health.v1.Health grpc.reflection.v1.ServerReflection grpc.reflection.v1alpha.ServerReflection temporal.api.operatorservice.v1.OperatorService temporal.api.workflowservice.v1.WorkflowService temporal.server.api.adminservice.v1.AdminService ```

Sounds good—though I thought `reset-batch` also supports more `--query` functionality than `batch` does today, does it not? Do we have something to track that missing functionality already?

D'oh, so I'm realizing we actually handled batch resets in #473. So I think this can be closed so long as we understand (and have other issues for) whatever functionality...

hm... I can easily imagine people wanting idempotent behavior from this command (e.g. if they're running it in a script); I wonder if we could instead add a flag to...

Hi @lorensr, why would we want to disable it at all?

Disabling CSRF can create unintended and surprising security risks even in local contexts. For example: https://www.oligo.security/blog/0-0-0-0-day-exploiting-localhost-apis-from-the-browser If you plan to use the server in a non-local context, you should use...