Joseph Schorr

Results 278 comments of Joseph Schorr

@jzelinskie actually doesn't matter, since .NET allows for type interop between languages

@jzelinskie With exception of being able to read the code in your preferred language, the UX is the same in VSCode

@benny-yamagata Yes, the replica URI parameter is a list of URIs and the system will round robin between them

> I don't think the implementation will work for that more common use case because the datastore snapshot reader does not use a single transaction. It uses a single connection,...

> > It uses a single connection, which means it should stay connected to the same replica > > I possibly just missed it, but it looked like you were...

Closing as the health check should now report whether the system is at the correct revision

I think making it configurable is reasonable

@benjamin99 We could in theory switch off of the VTMarshal for the caveat definitions to the standard, but strict, proto version. Can you construct a test exercising this issue and...

@benjamin99 Looks good. Can you also add a test into the caveat diff tests here: https://github.com/authzed/spicedb/blob/main/pkg/diff/caveats/diff_test.go I think we should be able to fix this problem by just switching the...

@benjamin99 Actually, looking at the diff lib, we even have the diff named right now as being a maybe: https://github.com/authzed/spicedb/blob/f42617656e03a0f6c760f602f2df3906e4483664/pkg/diff/caveats/diff.go#L155 So we could, if the bytes are different, deserialize strict...