John

Results 119 comments of John

That's a great point. So as long as we're talking about "wouldn't it be great if." It'd probably be best if match clauses, by default, never re-arranged themselves, but there...

Also: this should probably be updated so that if `.proxy_as(Class, :symbol)` is called on the query, the returns get overridden with the `:symbol` (like with `.pluck()`)

This PR follows what I proposed over in #308. Namely: > Calling .union() on a query always adds a new union clause to the query. Once added, that union clause...

@tjad I stopped pushing forward with this because `@cheerfulstoic` was busy at the time and because I was able to refactor my code to remove the need for a union...

Hey @pacso, it's quite possible that the comment I left on Jan 14th, 2019 was the last time I seriously looked at Ruby code. I'm definitely rusty at this point...

This was my first time submitting a PR using the new VSCode editor built into Github. Worked well.

> I think it's almost there, the only part that is not working now are optional path params, although I'm starting to doubt they ever worked correctly. Interesting. I wasn't...

(FYI, haven't forgotten about this--just been busy with the holidays. Might be another week or two before I can follow up.)

Ok, I've updated this PR to support optional params in addition to required params. I think it's ready to merge. Separately, I think it's possible that the `Router` methods should...